search

jinlow / forust

A lightweight gradient boosted decision tree package.
https://jinlow.github.io/forust/
Apache License 2.0
56 stars 6 forks source link

Fix paths for python install #11

Closed thomasaarholt closed 1 year ago

thomasaarholt commented 1 year ago

pip install forust (also for main branch) was throwing an error due to the paths for readme and license not being correct. This fixes that.

jinlow commented 1 year ago

Hello, Thanks for opening the pull request! Can I ask what OS you are using? When I run pip install it works and does not throw an error (tested on Windows and Ubuntu). However, I do see this error when I do a pip install and I install from a source .tar.gz file on pypi. In the CICD process I am copying the README and LICENSE into the py-forust directory, but I think it looks like I need to add a setting in the pyproject.toml to make sure these two files are included in the created source distribution.

jinlow commented 1 year ago

@thomasaarholt I made a new release, with the aforementioned fix to make sure the README and LICENSE files are included in the source distributions. Could you try installing again, and let me know if you have any problems? Thank you!

thomasaarholt commented 1 year ago

I was installing it on latest MacOS. The new version worked! :)