search

jinlow / forust

A lightweight gradient boosted decision tree package.
https://jinlow.github.io/forust/
Apache License 2.0
56 stars 6 forks source link

Missing test data #44

Closed MathisWellmann closed 1 year ago

MathisWellmann commented 1 year ago

Many tests (10) fail due to missing data, for example resources/contiguous_no_missing.csv is required by the test_bin_data test. Its important that this data is added to the repository or the tests must be changed.

jinlow commented 1 year ago

Hey @MathisWellmann, All of the test data is generated via a script in the scripts\ directory. To see how to set up your dev environment and run tests, please check out the contributing guide.
Thanks :)

jinlow commented 1 year ago

Although, I see now I only mention this script in the “running python tests” section, I’ll adjust the contributing guide to call it out as a prerequisite to running any tests.

MathisWellmann commented 1 year ago

Cool thanks for the update