jinlow / forust

A lightweight gradient boosted decision tree package.
https://jinlow.github.io/forust/
Apache License 2.0
56 stars 6 forks source link

Default value for l2 #97

Closed deadsoul44 closed 5 months ago

deadsoul44 commented 6 months ago

Default value for l2 reg should be 0.0

https://lightgbm.readthedocs.io/en/latest/Parameters.html#lambda_l2

jinlow commented 6 months ago

In the XGBoost docs, reg_lambda defaults to 1.0, so I think it's OK to also default to 1 in this library.

jinlow commented 5 months ago

Closing, as I think it's OK to align with xgboost.