search

jinmingjian / eclipse.themes.darker

eclipse themes - darker
Eclipse Public License 1.0
62 stars 12 forks source link

Styling Dialogs #19

Open vogella opened 11 years ago

vogella commented 11 years ago

Looks like the Dialogs, e.g. Preferences are not styled. Any plans to do this?

jinmingjian commented 11 years ago

two reasons make this hard:

  1. the widgets used in Dialogs/Preferences are varied;
  2. the "clientArea" (in my understanding) of Widget can not be style, which causes an ugly looking UI with white/black stripes instead.
jinmingjian commented 11 years ago

one example for why I say this is hard: issue #5

vogella commented 11 years ago

I think you cannot style Toolbars at the moment, but Dialogs are stylable.

2013/5/25 Jin Mingjian notifications@github.com

one example for why I say this is hard: issue #5https://github.com/jinmingjian/eclipse.themes.darker/issues/5

— Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/19#issuecomment-18448228 .

jinmingjian commented 11 years ago

I understand you, Lars.

There are many widgets on the Dialog. We are not clear exactly how many widgets does not support the style .Like the most used SWT Button, which does not support the style. That is why I implement one ICSSPropertyHandler here 1. But it is ulgy from several aspects. Maybe Text (on win32) is also in the same catalog.

does your "Dialogs are stylable" means we only make the dialog become dark but leave the widgets on it white? I personally do not think this is better than total white schema from aesthetics.

vogella commented 11 years ago

I would suggest to start styling the shell, so that the dialogs appear to be fitting with the background and afterwards see if widget need more styling. Once we see the limitations we can see if we can solve them via bug fixes.

2013/5/26 Jin Mingjian notifications@github.com

I understand you, Lars.

There are many widgets on the Dialog. We are not clear exactly how many widgets does not support the style .Like the most used SWT Button, which does not support the style. That is why I implement one ICSSPropertyHandler here 1https://github.com/jinmingjian/eclipse.themes.darker/blob/master/eclipse.themes.darker.ui/src/eclipse/themes/darker/ui/CSSPropertyDarkerButtonBackgroundColorHandler.java. But it is ulgy from several aspects. Maybe Text (on win32) is also in the same catalog.

does your "Dialogs are stylable" means we only make the dialog become dark but leave the widgets on it white? I personally do not think this is better than total white schema from aesthetics.

— Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/19#issuecomment-18457106 .

vogella commented 11 years ago

I think this screenshot shows the preferences in Intellj.

http://twitter.com/cyrilmottier/status/345111073847926785/photo/1

Did you already try to style the shell? Am 28.05.2013 12:37 schrieb "Lars Vogel" lars.vogel@gmail.com:

I would suggest to start styling the shell, so that the dialogs appear to be fitting with the background and afterwards see if widget need more styling. Once we see the limitations we can see if we can solve them via bug fixes.

2013/5/26 Jin Mingjian notifications@github.com

I understand you, Lars.

There are many widgets on the Dialog. We are not clear exactly how many widgets does not support the style .Like the most used SWT Button, which does not support the style. That is why I implement one ICSSPropertyHandler here 1https://github.com/jinmingjian/eclipse.themes.darker/blob/master/eclipse.themes.darker.ui/src/eclipse/themes/darker/ui/CSSPropertyDarkerButtonBackgroundColorHandler.java. But it is ulgy from several aspects. Maybe Text (on win32) is also in the same catalog.

does your "Dialogs are stylable" means we only make the dialog become dark but leave the widgets on it white? I personally do not think this is better than total white schema from aesthetics.

— Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/19#issuecomment-18457106 .

matthew-m commented 11 years ago

Look at MoonRise UI theme: https://github.com/guari/eclipse-ui-theme It provides a dark theme that changes the styles for pretty every widget that can be styled, Dialogs included. The result is nice and could be taken as basis to compare with dark Intellij Darcula theme. Anyway, there are still some elements that cannot be styled or have different behaviors on different operative systems while inheriting css rules, in fact if you look at the stylesheet you'll see that it has lots of workaround and 'hacks' to work properly.

jinmingjian commented 11 years ago

Hi, thanks for letting me know the new effort:) It is expected that he can get a well-look gtk(his Ubuntu Unity) version of dark theme.

But I am a little curious about his xp version's dark "Search" dialog(win7/win8 should be same, because SWT basically with win32)^_^ It seems he use pure css way in his plugin. In my understanding and communication to Lars previously, the whole nice experience can not be achieved by current CSS engine without modification to SWT. I guess you use Ubuntu, but I think you know the pain of windows users in an ugly experience.

how do we do?...

best regards, Jin

guari commented 11 years ago

Hi Jin (and, of course, thanks @matthew-m ), as you noticed till now I preferred to use a pure CSS approach for customizations, I needed to apply some 'dirty' workarounds in CSS to achieve that, but I obtained a 'full' dark theme for any Eclipse window (not only the main IDE).

I tested my plugin with the main Eclipse Development Tool plugins on Ubuntu (it should be indipendent from the system theme used, the screenshot on my page is with default light theme), Windows (7) and OSX (it needs a 'patched' version since there are some anomalies on how are inherited some CSS rules compared to other platforms).

The more noticeable issues related to SWT, as well known, are the ScrollBar widgets, the Table headers/lines and the arrows to fold/unfold contents that cannot be styled (it would be nice to have a selector or a property exposed to CSS for it in next Eclipse builds..). As minor issues there are Buttons background color on Win and OSX that cannot be styled but they do not look so dissonant (but on Win the checkboxes do not inherit font color), then there are some other little bugs related to e4 engine that cannot be bypassed at the higher plugin level.

On Windows there is the worst look: screenshot_00

Aside from that, in my experience, the result might not look perfect on each platform, however can be fully useable on all of them with a proper stylesheet customization, you can try yourself on your machine my package, just put the jar into your dropins folder.

To quickly see what elements can be changed or not with CSS, I suggest to open CSS Scratchpad or Lightweight CSS Editor and drop only this line: * { background-color:black; color:white; } (note that if you plan to set different colors for many widgets you'll have to face lots of anomalies..)

Best regards and sorry for the 'intrusion' :) Andrea

jinmingjian commented 11 years ago

Hi, Andrea, thanks for intrusion:)

I think you still do a very great job in the dark side Eclipse 4 theme! The feeling under windows 7 seems much better than my old tweaking in one of my old XP:)

If you are active in this dark theme side, I'd like to suggest Lars and other newcomers turn into your project to gain continuous supports. Because I am using IDEA 13 for a while, I am not sure that I have any time to add new things in this side in some relative long recent time.

best regards, Jin

guari commented 11 years ago

thanks Jin, I'm glad you like it, to be honest I switched as well to IntelliJ IDE some months ago for my works (for my needs, it provides a more solid structure and more advanced tools for web/mobile development). Eclipse has been however my main IDE for years and it's still widespread so I'm pleased to help improving at least its look and feel time to time.