jinnhl / pe

0 stars 0 forks source link

Duplicate detection allowing similar names to be added #3

Open jinnhl opened 2 years ago

jinnhl commented 2 years ago

Problem: Dummy 6 and Dummy 6 can be added, bypassing duplicate detection.

Reason: People with names that differ only by the number of white spaces between each word are likely to be the same

Steps:

add n/Dummy 6 p/98765432 e/j@com a/John street, block 123,#01-01 pr/north,123 Street,1-room,$300000

add n/Dummy 6 p/98765432 e/j@com a/John street, block 123,#01-01 pr/north,123 Street,1-room,$300000

Screenshot 2022-04-16 at 2.46.20 PM.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate Detection (Name)

Currently, the add command doesn't detect duplicates when two clients are added with same details but with different name case. E.g. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123,#01-01 pr/north,123 Street,1-room,$300000 and add n/john doe p/98765432 e/johnd@example.com a/John street, block 123,#01-01 pr/north,123 Street,1-room,$300000 Works when they are the same client.


[original: nus-cs2103-AY2122S2/pe-interim#3358] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The dev team accepts this issue, but doesn't feel that it's a vey severe issue, hence a severity of Low has been reassigned

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]