nus-pe-script
commented
2 years ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Lower Price and Higher Price of Preference tag
To replicate: Simply add a client, set lower price to 1, set higher price to 1 under the preference tag. Reason: Should ensure that higher price entered is always higher than lower price entered. Vice versa
[original: nus-cs2103-AY2122S2/pe-interim#1767] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
The dev team feels that it's possible for the higher price & lower price to be the same as a buyer may wish to strictly have a single value that he wants to purchase a property for, instead of a range
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Reason why I find the range enforcement to be necessary was due to how they find matches.
Matches are found if the property price is
1) more than or equals to the low price
AND
2) less than or equals to the high price
The dev team's response to allow buyer's to set a single price would mean that the match feature would only come up with matches when properties are sold at the same exact price. Such a scenario is incredibly unlikely, hence breaking the match feature.
:question: Issue severity
Team chose [severity.Medium]
Originally [severity.Low]
- [x] I disagree
Reason for disagreement: As mentioned previously by allowing buyer's to set a single price, the match feature would be unreliable. The occurrence is dictated by how many buyer's set only one price. And for every of such buyer, due to the before mentioned unlikelihood of matching the prices exactly, they will be stuck in a forever limbo. On top of that, the real estate agent will not have any indication or warnings of such occurrence.
Problem: High price and low price being identical is allowed
Reason: Since the intention of having a higher and lower price is to capture a range of prices, the buyer is willing to pay. Seems unrealistic to have buyers who are dead set on only 1 price.
Step:
add n/1Betsy Crowe e/betsycrowe@example.com a/Newgate Prison p/1234567 pf/West, 1-room, $100000, $100000