search

jinsc37 / DIFRINT

TOG20/SIGGRAPH Asia19 "Deep Iterative Frame Interpolation for Full-frame Video Stabilization" - PyTorch
81 stars 23 forks source link

Homography decomposition #6

Open stefanklut opened 3 years ago

stefanklut commented 3 years ago

Hi there,

Awesome work, I just have a couple of questions on the metrics.py

Currently I believe the scale extraction and the rotation extraction are done incorrectly. Based on https://math.stackexchange.com/questions/78137/decomposition-of-a-nonsquare-affine-matrix taking the diagonal of the matrix seems incorrect for computing these values. I am happy to discuss this with you.

Thanks in advance

jinsc37 commented 3 years ago

Hi, sorry for the late reply Could you send a PR? I can look through it Thanks!

On Wed, Apr 14, 2021 at 3:52 AM Stefan Klut @.***> wrote:

Hi there,

Awesome work, I just have a couple of questions on the metrics.py

Currently I believe the scale extraction and the rotation extraction are done incorrectly. Based on https://math.stackexchange.com/questions/78137/decomposition-of-a-nonsquare-affine-matrix taking the diagonal of the matrix seems incorrect for computing these values. I am happy to discuss this with you.

Thanks in advance

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jinsc37/DIFRINT/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE2XT6KZ3OIOY6RQLYK25NLTIVXXZANCNFSM425ENZYQ .