search

jinsen47 / PokeFaker

An Xposed plugin to play Pokemon Go freely.
MIT License
38 stars 11 forks source link

replace Dpad view with a joystick which is get from https://github.co… #11

Closed hello-earth closed 8 years ago

hello-earth commented 8 years ago

…m/GcsSloop/Rocker

jinsen47 commented 8 years ago

Great Job, do you mind a code review before a merge?

hello-earth commented 8 years ago

i have remove the label "singleTask" from AndroidManifest the close button is want to switch status between walk and move joystick, now it've done. fix lib bug in TimerTask, thx. about multidex: when the number of function name over 65535, it'll work; if not, it's nothing to do. this code have run on my phone, it's ok.

jinsen47 commented 8 years ago

Thanks. Found two bugs. RockerView still call listener even when the window is not in the foreground. RockerView wont call listener when the view is pressed and held.

hello-earth commented 8 years ago

if you don't mind, i'll remove the class (welcome), i think almost function move to MainActivity should more wonderful.

hello-earth commented 8 years ago

about two bugs: i'll fix that.

jinsen47 commented 8 years ago

Move some permission works to MainActivity means more dialog and buttons, I 'll do this by myself, thanks all the same.

jinsen47 commented 8 years ago

The second bug is not an actual bug. System won't send more motion events when it detects the finger didn't move, and the motion event action is as below: DOWN->MOVE->MOVE->MOVE......(it waits here) When RockerView get no futher actions, it will call the listener in a fixed frequency(mRereshCycle), and the frequency is too small to use.

jinsen47 commented 8 years ago

About the multidex, maybe you got some misunderstandings. The Android Gradle plugin started to support Instant Run in the 2.0 version. The instant run use the feature of multidex, and that feature is not supported by Xposed. That is why I don't use the newest version. The multidex feature is not applied in release build, and you could feel free to use when your are debuging, but I prefer dont to change it in the commit file, maybe a trick to someone forked this repo.

jinsen47 commented 8 years ago

@hello-earth Hi, mate, I fixed both bugs, and please dont mind them anymore.

jinsen47 commented 8 years ago

If you have nothing to commit, I'll merge this pr.

hello-earth commented 8 years ago

ok

jinsen47 commented 8 years ago

@hello-earth Hi bro, I add the power parameter to RockerView(the distance between center and touched position), and temporary remove the zoom parameter. Keep you noticed.