jinxdash / prettier-plugin-rust

Prettier Rust is an opinionated code formatter that autocorrects bad syntax.
MIT License
178 stars 7 forks source link

Why a new VSCode extension? #1

Closed JounQin closed 2 years ago

JounQin commented 2 years ago

Doesn't this plugin work perfectly with the official one?

jinxdash commented 2 years ago

How'd you install a prettier plugin in a rust project?

JounQin commented 2 years ago

How'd you install a prettier plugin in a rust project?

npm i -g prettier prettier-plugin-rust

jinxdash commented 2 years ago

How do you update the plugin when there's a new version?

JounQin commented 2 years ago

How do you update the plugin when there's a new version?

npm upgrade -g prettier-plugin-rust

or

npm upgrade -g --latest

JounQin commented 2 years ago

There are a lot of prettier plugins supporting other languages, we don't need/want every one prettier plugin requires a new VSCode extension. 😂

jinxdash commented 2 years ago

How do you update the plugin when there's a new version?

npm upgrade -g prettier-plugin-rust

Right, so let's keep in mind that the rust userbase is not necessarily familiar with npm, and is unlikely to even have the core extension to begin with. A standalone extension makes the installation easier for everyone, and has auto-updates built-in

[...] plugin requires a new VSCode extension. 😂

Installing the standalone extension is not required, you're free to use the plugin however you see fit

I'll update the README to clear the confusion ~

JounQin commented 2 years ago

Installing the standalone extension is not required, you're free to use the plugin however you see fit

I know the extension is not required, but as I mentioned above, a new extension for every prettier language plugin is just confusing and unexpected IMO.

I don't see VSCode extensions for @prettier/plugin-ruby or prettier-plugin-java for example.

prettier is a node module, so whoever wants to use it should already know about that.

A new extension for every prettier language prettier is a bad practice, sorry I may be rude here.