search

jinxdash / prettier-plugin-rust

Prettier Rust is an opinionated code formatter that autocorrects bad syntax.
MIT License
180 stars 8 forks source link

Sometimes splits on module resolution (`::`) #31

Open bbugh opened 1 year ago

bbugh commented 1 year ago

Input code

// Default rustfmt 
    let data = 
        fs::read_to_string(&json_path).unwrap_or_else(|_| panic!("Unable to read {:?}", json_path));

Output code

// prettier-plugin-rust
    let data = fs
        ::read_to_string(&json_path)
        .unwrap_or_else(|_| panic!("Unable to read {:?}", json_path));

Additional context

fs::read_to_string shouldn't be broken across lines, it's a single qualified value.

It only does this sometimes, not in a way that I can reproduce. There's many other cases in my code where it didn't do this, for example:

                    DefaultMakeSpan::new().include_headers(true).level(tracing::Level::DEBUG)
jinxdash commented 1 year ago

Thanks for the report! This is intended behavior. :: is intended to sometimes break to improve readability, this is based on conditions similar to breaking chain calls.

All styling decisions in this formatter are acquired from prettier core, and I'm reluctant to make changes to it

With that said, there are exceptions in core to never break on a few widely used javascript-specific names such as it.<method> from testing libraries. Maybe fs should get that treatment, I'm not sure.