jinyang628 / pe

0 stars 0 forks source link

Real legal names with symbols are detected as invalid #2

Open jinyang628 opened 10 months ago

jinyang628 commented 10 months ago

image.png

Since this application is built for transaction recording, it is important that the full legal name can be inputted even if it contains special characters like /

nus-se-bot commented 10 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name doesn't allow special characters

Certain individuals may have non-alphanumeric characters in their names. The current application limits this by throwing an error message when i.e., John s/o Doe is used as the name in the addstaff command.

Command input: addstaff n/John s/o Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney

Output: Names should only contain alphanumeric characters and spaces, and it should not be blank

Screenshot 2023-11-17 at 4.26.06 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#1570] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We do see the inconvenience this causes for people with certain characters in their name.

However, we will classify it as Not In Scope as accounting for such cases will require an overhaul of the parsing system, hence there is a low value/effort ratio considering the user can omit the / or replace it with a space without impacting the identifiability of the name much. It is also mentioned in the UG that names only accept letters and digits, and fails gracefully with an error message, hence fulfilling the condition for NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/jinyang628/pe/main/files/029fb31f-e10a-441e-9d06-ebd09ef18a33.png) ![image.png](https://raw.githubusercontent.com/jinyang628/pe/main/files/c0d3e04d-9927-4c7b-8a8b-8e51f945a58a.png) This application is built to track transactions and the people involved with these transactions. For this use case, **full legal names** are important (we might need the full legal name when doing bank transfers to staff members, when filling up legal contracts, quotations, reimbursements, etc.). ![image.png](https://raw.githubusercontent.com/jinyang628/pe/main/files/09353d5d-de3a-4d59-9462-8565f5638a6b.png) From the CS2103T website, we can consider this bug as a FeatureFlaw because disallowing the symbols in names can cause major inconveniences - we have good reason to believe that in this context, matching the **full legal name** is extremely important. Every time I see a space in a name, I have to second-guess myself and check if that space actually represents a space, or is it a '/' or is it a '-', etc. as numerous names have special symbols. This opens up room for mistakes and slows down the transaction management significantly. ![image.png](https://raw.githubusercontent.com/jinyang628/pe/main/files/fd934914-0b95-49a5-8f5c-d3bef2399b92.png) Because fixing the feature flaw is important for the app to be useful for its use case, I do not believe that NotInScope is appropriate. I will, however, agree to lowering the severity to Low as replacing symbols with a space is an acceptable (though very undesirable) alternative.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]