jinyang628 / pe

0 stars 0 forks source link

Phone number does not accept country code with a + #7

Open jinyang628 opened 10 months ago

jinyang628 commented 10 months ago

image.png

Phone number parameter only accepts numbers, but not a country code. It is possible that you have a contacts who live in the US and you have transactions with him that you want to track. His phone number will be in US country code and you will want to track that.

Given the context of this application , "startups or small scale retailers looking for a cheap and efficient way to record daily transactions", it is very likely for startups to have sellers/buyers overseas and this is not a very rare occurrence. Hence, severity.Medium

nus-se-bot commented 10 months ago

Team's Response

We have specified that the phone number will only contain numbers. Our software's target users are small and medium-sized enterprises, so staff are likely to have phone numbers with the same country code. It is impractical for a staff working in a small business like a small restaurant to continue using a foreign phone number in the long term due to more expensive fees and inferior service. Moreover, if we are to allow for different country codes, non-trivial effort is needed to verify if the country code exists. So we stick to the current implementation and consider the above issue as Not In Scope.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]