4.17 Build with new features?

Derjyn commented 6 years ago

I've been trying to merge in some of the changes, back to the last version that was compatible with 4.17, and am running into issues. Are you no longer supporting 4.17?

jinyuliao commented 6 years ago

I've pushed a branch: 4.17, bring new features to UE 4.17, you can check it out.

Derjyn commented 6 years ago

Thanks for that. Though cleaning up my project, adding that new version, then generating VS project files and trying to compile yields no results. It's as if the plugin doesn't exist. It's in the VS solution/project, but nothing compiles for it. I repeated the process for other plugins, and they worked fine. I repeated it for an older version of GenericGraph, and it worked fine.

Derjyn commented 6 years ago

Correction to my last statement: I just realized I downloaded the base of that 4.17 branch. I grabbed the version with the latest commit, and it compiles now. Thanks, and I'm marking this as solved!

Derjyn commented 6 years ago

I spoke too soon- shipping build won't compile:

GenericGraphRuntime\Private\GenericGraph.cpp(45): error C2065: 'GEngine': undeclared identifier AND

GenericGraphRuntime\GenericGraphNode.gen.cpp(214): error C2039: 'ContextMenuName': is not a member of 'UGenericGraphNode'
GenericGraphRuntime\GenericGraphNode.gen.cpp(214): error C2664: 'UTextProperty::UTextProperty(const UTextProperty &)': cannot convert argument 1 from 'FObjectInitializer' to 'ECppProperty'
GenericGraphRuntime\GenericGraphNode.gen.cpp(215): error C2039: 'BackgroundColor': is not a member of 'UGenericGraphNode'
GenericGraphRuntime\GenericGraphNode.gen.cpp(215): error C2664: 'UStructProperty::UStructProperty(const UStructProperty &)': cannot convert argument 1 from 'FObjectInitializer' to 'ECppProperty'
GenericGraphRuntime\GenericGraphNode.gen.cpp(216): error C2039: 'CompatibleGraphType': is not a member of 'UGenericGraphNode'
GenericGraphRuntime\GenericGraphNode.gen.cpp(216): error C2664: 'UClassProperty::UClassProperty(const UClassProperty &)': cannot convert argument 1 from 'FObjectInitializer' to 'ECppProperty'

I fixed the first issue by commenting out the GEngine block in GenericGraph.cpp:

//if (ToScreen && GEngine != nullptr)
//{
//    GEngine->AddOnScreenDebugMessage(-1, 15.f, FColor::Blue, Message);
//}

The generated issues are still there, though. Any help is much appreciated!

jinyuliao commented 6 years ago

I've pushed a fix on master and 4.17 branch, you can update and try again.

Derjyn commented 6 years ago

Awesome, thanks. Almost there- compiled for both Development Editor and Shipping builds without issue. However, creating a new generic graph asset has some issues. Firstly, the details panel has "unrecognized tab", with no options accessible. Second, the "Generic Graph Settings" window appears to have some non-agnostic sample material left in there. Not sure if this is by design or not, or how many versions that has been present. See the attached screenshots.

Thanks for being so quick and attentive, much appreciated. I'll keep testing over the next couple of days while I'm working on other elements of my project. This is a handy asset to have in the toolbelt, I'm surprised it hasn't gotten more attention!

capture capture2

jinyuliao commented 6 years ago

“unrecognized tab” caused by a rename of the panel, you can just close it and click the "Window->property" to open the new property window.
"Generic Graph Settings" has some parameters to adjust “auto arrange”'s behavior, the name come from the arrange algorithm, most of the time, you don't need change the settings, especially the advance setting.
From your screenshots, the AutoArrange's icon seems has some problem, the icon file 's path is ${Plugins}/GenericGraph/Resources/AutoArrangeIcon.png Finally, your asset editor should looks like this:

Derjyn commented 6 years ago

Perfect, thanks for clearing those issues up. Shortly after posting, I pondered about the names of those items in the graph settings, and the thought crossed my mind that they might actually be related to the auto-arrange. Interesting!

I double checked the location of the auto-arrange icon, and it's in it's proper place. I recompiled the plugin, making sure it was in the correct directory, but it still shows up white. Before you pointed that out, I actually thought it was an issue with Slate rendering having an attitude... I have a screenshot to verify that it's in the proper place.

capture

Derjyn commented 6 years ago

Okay, I did a more in-depth project cleanup and rebuilt the plugin again, as well as reset all my customized settings. The icon shows up correctly now. Outside of more in-depth testing, so far everything seems to be operating as it should!

Marking this as closed again. Thanks for all the assistance. Hopefully I won't be back with more issues 👶

jinyuliao / GenericGraph

4.17 Build with new features? #3