search

jinyun1tang / ECOSYS

The ECOSYS model for terrestrial ecosystem biogeochemistry
BSD 3-Clause "New" or "Revised" License
48 stars 38 forks source link

Identical inputs but diverse outputs. Dry matter and LAI near to zero for the latest version #16

Closed qiyang77 closed 2 years ago

qiyang77 commented 2 years ago

Hello there, I am a beginner of this model and I simply run the "dryland_maize example". For 2001, the output dry matter and LAI is extremly small when the wheather data seems ok. It is very werid. As a result, I compiled and ran multiple versions of ecosys and the results are very diverse despite the same input. The inputs are exactly the same as the latest dryland_maize 2001 files image image image

The outputs of the latest version and the version of 2021-12-6 are identical, but the grain C is always zero. Could you please tell me why this happen, did I miss something? And, what's your suggestion?

jinyuntang commented 2 years ago

Qi A good way is to check into the readi.f, reads.f and readq.f to understand how the inputs are read by the code. If I recall correctly, the different versions have some difference in their requirement of input files. Also to remember, I have not checked the scientific validity of those examples, as my effort is spent somewhere else, and I am not paid to make everything right for those examples. One suggestion I have is that you may contact someone from Kaiyu Guan's group at UIUC, they have some run cases that are giving reasonable results with the code (e.g. the leading author from the paper https://www.sciencedirect.com/science/article/pii/S0168192321002057). Best Jinyun

On Sat, Mar 26, 2022 at 2:54 PM QiYang @.***> wrote:

Hello there, I am a beginner of this model and I simply run the "dryland_maize example". For 2001, the output dry matter and LAI is extremly small when the wheather data seems ok. It is very werid. As a result, I compiled and ran multiple versions of ecosys and the results are very diverse despite the same input. The inputs are exactly the same as the latest dryland_maize 2001 files [image: image] https://user-images.githubusercontent.com/23078349/160258123-736fd4e7-2aaa-44e1-9240-6c5963272584.png [image: image] https://user-images.githubusercontent.com/23078349/160258142-599fa23f-8d62-4a0d-a7bf-9fc8f9ebf592.png [image: image] https://user-images.githubusercontent.com/23078349/160258144-7b542ad8-7c51-4111-ac09-36ac19763475.png

The outputs of the latest version and the version of 2021-12-6 are identical, but the grain C is always zero. Could you please tell me why this happen, did I miss something? And, what's your suggestion?

— Reply to this email directly, view it on GitHub https://github.com/jinyun1tang/ECOSYS/issues/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTQV3S2PMZHWIFSZKMCZZLVB6BQTANCNFSM5RXXFPCA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Staff Scientist Lawrence Berkeley National Laboratory 1 Cyclotron Rd., MS 74R316C Berkeley, CA 94720 tel: 510 486-5792, fax: 510 486-7070

Zhenong commented 2 years ago

Hi Jinyun,

Sorry for the confusion. Qi is a new postdoc in my lab. I asked him to learn ecosys, and looks like he went ahead and has started testing different versions.

I will ask him to join the Thursday meeting to be synchronized.

Thanks, Zhenong

On Sat, Mar 26, 2022 at 6:02 PM jinyuntang @.***> wrote:

Qi A good way is to check into the readi.f, reads.f and readq.f to understand how the inputs are read by the code. If I recall correctly, the different versions have some difference in their requirement of input files. Also to remember, I have not checked the scientific validity of those examples, as my effort is spent somewhere else, and I am not paid to make everything right for those examples. One suggestion I have is that you may contact someone from Kaiyu Guan's group at UIUC, they have some run cases that are giving reasonable results with the code (e.g. the leading author from the paper https://www.sciencedirect.com/science/article/pii/S0168192321002057). Best Jinyun

On Sat, Mar 26, 2022 at 2:54 PM QiYang @.***> wrote:

Hello there, I am a beginner of this model and I simply run the "dryland_maize example". For 2001, the output dry matter and LAI is extremly small when the wheather data seems ok. It is very werid. As a result, I compiled and ran multiple versions of ecosys and the results are very diverse despite the same input. The inputs are exactly the same as the latest dryland_maize 2001 files [image: image] < https://user-images.githubusercontent.com/23078349/160258123-736fd4e7-2aaa-44e1-9240-6c5963272584.png

[image: image] < https://user-images.githubusercontent.com/23078349/160258142-599fa23f-8d62-4a0d-a7bf-9fc8f9ebf592.png

[image: image] < https://user-images.githubusercontent.com/23078349/160258144-7b542ad8-7c51-4111-ac09-36ac19763475.png

The outputs of the latest version and the version of 2021-12-6 are identical, but the grain C is always zero. Could you please tell me why this happen, did I miss something? And, what's your suggestion?

— Reply to this email directly, view it on GitHub https://github.com/jinyun1tang/ECOSYS/issues/16, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACTQV3S2PMZHWIFSZKMCZZLVB6BQTANCNFSM5RXXFPCA

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Staff Scientist Lawrence Berkeley National Laboratory 1 Cyclotron Rd., MS 74R316C Berkeley, CA 94720 tel: 510 486-5792, fax: 510 486-7070

— Reply to this email directly, view it on GitHub https://github.com/jinyun1tang/ECOSYS/issues/16#issuecomment-1079790724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBEJEZRWEBGTF6D5SSRHATVB6JRBANCNFSM5RXXFPCA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Zhenong Jin Assistant Professor University of Minnesota - Twin Cities Department of Bioproducts and Biosystems Engineering Institute on the Environment Associates http://jinlab.bbe.umn.edu/

qiyang77 commented 2 years ago

Hi Jinyun,

Thank you for your suggestions, I will check the code to make sure it gets the matched inputs.

Best, Qi

jinyuntang commented 2 years ago

Zhenong Not a problem.

Jinyun

On Sat, Mar 26, 2022 at 4:17 PM Zhenong Jin @.***> wrote:

Hi Jinyun,

Sorry for the confusion. Qi is a new postdoc in my lab. I asked him to learn ecosys, and looks like he went ahead and has started testing different versions.

I will ask him to join the Thursday meeting to be synchronized.

Thanks, Zhenong

On Sat, Mar 26, 2022 at 6:02 PM jinyuntang @.***> wrote:

Qi A good way is to check into the readi.f, reads.f and readq.f to understand how the inputs are read by the code. If I recall correctly, the different versions have some difference in their requirement of input files. Also to remember, I have not checked the scientific validity of those examples, as my effort is spent somewhere else, and I am not paid to make everything right for those examples. One suggestion I have is that you may contact someone from Kaiyu Guan's group at UIUC, they have some run cases that are giving reasonable results with the code (e.g. the leading author from the paper https://www.sciencedirect.com/science/article/pii/S0168192321002057). Best Jinyun

On Sat, Mar 26, 2022 at 2:54 PM QiYang @.***> wrote:

Hello there, I am a beginner of this model and I simply run the "dryland_maize example". For 2001, the output dry matter and LAI is extremly small when the wheather data seems ok. It is very werid. As a result, I compiled and ran multiple versions of ecosys and the results are very diverse despite the same input. The inputs are exactly the same as the latest dryland_maize 2001 files [image: image] <

https://user-images.githubusercontent.com/23078349/160258123-736fd4e7-2aaa-44e1-9240-6c5963272584.png

[image: image] <

https://user-images.githubusercontent.com/23078349/160258142-599fa23f-8d62-4a0d-a7bf-9fc8f9ebf592.png

[image: image] <

https://user-images.githubusercontent.com/23078349/160258144-7b542ad8-7c51-4111-ac09-36ac19763475.png

The outputs of the latest version and the version of 2021-12-6 are identical, but the grain C is always zero. Could you please tell me why this happen, did I miss something? And, what's your suggestion?

— Reply to this email directly, view it on GitHub https://github.com/jinyun1tang/ECOSYS/issues/16, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACTQV3S2PMZHWIFSZKMCZZLVB6BQTANCNFSM5RXXFPCA

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Staff Scientist Lawrence Berkeley National Laboratory 1 Cyclotron Rd., MS 74R316C Berkeley, CA 94720 tel: 510 486-5792, fax: 510 486-7070

— Reply to this email directly, view it on GitHub <https://github.com/jinyun1tang/ECOSYS/issues/16#issuecomment-1079790724 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADBEJEZRWEBGTF6D5SSRHATVB6JRBANCNFSM5RXXFPCA

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Zhenong Jin Assistant Professor University of Minnesota - Twin Cities Department of Bioproducts and Biosystems Engineering Institute on the Environment Associates http://jinlab.bbe.umn.edu/

— Reply to this email directly, view it on GitHub https://github.com/jinyun1tang/ECOSYS/issues/16#issuecomment-1079792497, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTQV3TXDNKETYPSMABS37TVB6LHLANCNFSM5RXXFPCA . You are receiving this because you commented.Message ID: @.***>

--

Staff Scientist Lawrence Berkeley National Laboratory 1 Cyclotron Rd., MS 74R316C Berkeley, CA 94720 tel: 510 486-5792, fax: 510 486-7070