search

jinyun1tang / ECOSYS

The ECOSYS model for terrestrial ecosystem biogeochemistry
BSD 3-Clause "New" or "Revised" License
52 stars 40 forks source link

Dev #17

Closed DinisDimitris closed 1 year ago

DinisDimitris commented 1 year ago

FYI

jinyun1tang commented 1 year ago

Hello @DinisDimitris, very impressive effort. I did notice some of the output variables renaming in fouts.f is not quite meaningful. E.g. SURF_WTR_18 to replace WTR_18. In the code, 18 means layer, and the code represents layers from 1 to 18 (by assumption, and sometimes is less than 18, and is set by JZ). In addition, SURF means above layer 1, or 0 (which indicates litter layer if it exists). Therefore, I would suggest revert this part of change.

DinisDimitris commented 1 year ago

Hi @jinyun1tang yes thats not too meaningful. I didnt realise i PR'ed that part as well, i thought i just committed that to my fork, as it helps with non duplicate columns in my models. Will revert that, will only leave the instructions folder.