style: simplify shouldIgnore - Githubissues

jinzhu / copier

Copier for golang, copy value from struct to struct and more

MIT License

5.58k stars 489 forks source link

style: simplify shouldIgnore #126

Closed ag9920 closed 2 years ago

ag9920 commented 2 years ago

Just simplify some code, no real logic update.

Reduce the length of shouldIgnore function to one line.
Add name for returned variable in TypeConverter to make it more understandable.
Replace errors.New with defined ErrFieldNameTagStartNotUpperCase in errors.go.
Early return in set function, to avoid the long if from.IsValid() statement.