search

jinzhu / vrome

Vrome: Bringing Vim elegance to Chrome
Other
618 stars 107 forks source link

Searching on a page that starts with $ freezes all #324

Closed agzam closed 10 years ago

agzam commented 10 years ago

Apparently can't search if you're searching for something that starts with "$" sign... something like "$compile" or "$timeout". Reloading the page won't help, you have to close the tab and re-open

freeo commented 10 years ago

The search function uses regular expressions by default. "$" is a special character in regex, it translates to "end of the line". In regex terms, searching something after $ is never needed. Your search doesn't terminate correctly, so it's some kind of a bug, but that's not important. To use "$" as a literal character you have to escape it properly like so: "\$compile". If you don't like regex search, then fall back to chromes builtin search, but remember in case when normal search isn't enough, that regex is far superior. (This issue should be closed)

agzam commented 10 years ago

Wow... yes... of course regex search... What I was thinking? Thanks! BTW, please fix 'go to buffer' feature. It finds and deletes the tab 'Shift+b', but finding and switching is broken...