search

jinzihan2002 / pe

0 stars 0 forks source link

`WARNING` logging information is displayed for invalid inputs #3

Open jinzihan2002 opened 1 week ago

jinzihan2002 commented 1 week ago

image.png How to reproduce:

When an invalid command is entered (not necessarily just the command above), the UI prints out some WARNING logging information, as well as the location in the source code the exception occurred (seedu.exchangecoursemapper.parser.Parser processUserInput in this case). As such information does not need to be seen by the end user, perhaps the exception could be better handled to only display the final error message to the user.

nus-se-bot commented 6 days ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Logger warning appears

image.png

I think you can hide the logger warning information as it is irrelevant to the user

Steps to replicate: invalid command

[original: nus-cs2113-AY2425S1/pe-interim#18] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the feedback! This can be fixed easily in the next iteration by setting the logger levels, and does not bring any issues to the running of our software.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** The dev team responded that "This can be fixed easily in the next iteration", but the course website's PE section states that this would not qualify for "NotInScope" if it can be rectified without much additional effort: ![image.png](https://raw.githubusercontent.com/jinzihan2002/pe/main/files/120fa384-eaa1-45e9-8483-2e05f2da9319.png)
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** I believe the bug is still a FeatureFlaw, as it does perform as expected to inform of invalid commands, but it provides extra logging information that is not useful for the target user.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I believe the bug is not of VeryLow severity, as the end user does not and should not need to see extraneous logging information including where the exception occurred in the source code, thus it is not merely a cosmetic bug.