search

jipiboily / forwardlytics

[DEPRECATED & UNMAINTAINED] Take events and customer data in and send them to various providers, mostly analytics providers.
https://jipiboily.com/
MIT License
58 stars 7 forks source link

Drip integration added #40

Closed jonashelgemo closed 8 years ago

jonashelgemo commented 8 years ago

Probably some small stuff that still needs fixing, but as far as I know this works. My Golang skills are still pretty basic, so please comment if there are stuff in here that I should have done differently.

jonashelgemo commented 8 years ago

There are some Timezone issues that break the tests in Travis. I'll have a look and fix them soon.

jipiboily commented 8 years ago

Yeah, time comparison sometime sucks. Let me know when it's done and I'll review then. No rush, I won't be able to review for a few days anyways.

jonashelgemo commented 8 years ago

So I have fixed the tests and the typos in the urls.

jipiboily commented 8 years ago

Awesome, thanks! I'll finish the review later, I had to put it on hold due to emergencies.

jipiboily commented 8 years ago

That said, at first it looked pretty good 😀

jonashelgemo commented 8 years ago

Cool!

jipiboily commented 8 years ago

@helgeblod good job man! Only a few things here and there, honestly nothing big. Keep it coming!

jonashelgemo commented 8 years ago

I think the drip integration is complete now with regards to your comments. If there is more, feel free to comment 😃

jipiboily commented 8 years ago

Good job @helgeblod! Thanks ❤️ . Deploying and starting to test shortly.

jonashelgemo commented 8 years ago

Cool! On to the next one then I guess 👍