search

jipiboily / monologue

Monologue is a basic blogging engine. It is a Rails mountable engine you can mount in your already existing Rails app, or a in a new one! Enjoy.
http://jipiboily.com/2013/monologue-0-3-0-released-and-monologue-markdown
MIT License
477 stars 196 forks source link

upgrade all the things (upgrade to Rails 5) #301

Closed jipiboily closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-21.3%) to 75.491% when pulling 5e45bcfd65d334b79fc2343bb4f4bf2d9a6ba1d8 on upgrade-ruby-support into eb86247e948a6f4bba63c03d4151fc461b0c412f on master.

illegalnumbers commented 7 years ago

Let's merge this! Some of my builds fail due to some of the older Ruby versions problems.

jipiboily commented 7 years ago

@illegalnumbers yeah, not that I don't want to but I was not able to figure it out when I looked briefly last week. Any idea maybe? I can look a bit later.

illegalnumbers commented 7 years ago

Honestly I really wasn't even able to get the test suite up and running locally since it's dependencies are so out of date...it might just be worth it to merge this guy in to get the builds to build the right Ruby versions and then just update the other libraries and fix tests on an as needed basis.

msevestre commented 7 years ago

Time to move on indeed :)

jipiboily commented 7 years ago

Going to work on this shortly.

jipiboily commented 7 years ago

ok, this isn't going to be trivial. We need a full upgrade, and it hasn't happened in a while.

There are a lot of deprecations, which we can live with for a few weeks/months until Rails 5.1 is out. That said, I can't get the tests running locally at all. I removed some gems, upgraded others, still not working.

Issues are with the Capybara tests (surprise! This is brittle!).

If someone wants to make Monologue Rails 5.0 compatible and ideally 5.1 ready, get in touch please. I can pay $100. It's not a lot, but it's open source and I don't even use it myself anymore 😀

jipiboily commented 7 years ago

Closing in favor of https://github.com/jipiboily/monologue/issues/314