search

jipiboily / monologue

Monologue is a basic blogging engine. It is a Rails mountable engine you can mount in your already existing Rails app, or a in a new one! Enjoy.
http://jipiboily.com/2013/monologue-0-3-0-released-and-monologue-markdown
MIT License
477 stars 196 forks source link

modified migration files #312

Closed omricohen closed 1 year ago

omricohen commented 7 years ago

I removed all the migration updates and moved them into 4 their respective create migrations. This will greatly simplify new installs.

msevestre commented 7 years ago

I fixed the build. Should be back in businesss soon

msevestre commented 7 years ago

@omricohen could you somehow update that PR to trigger the build again?Thanks

omricohen commented 7 years ago

@msevestre I did -- still failed

msevestre commented 7 years ago

yeah thanks. @jipiboily is going to look into that soon :)

On Tue, Mar 7, 2017 at 11:39 AM Omri Cohen notifications@github.com wrote:

@msevestre https://github.com/msevestre I did -- still failed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jipiboily/monologue/pull/312#issuecomment-284777947, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_jVYImMP3CwUH1l0oEjsNtaOiytILrks5rjYg3gaJpZM4MPoMc .

jipiboily commented 7 years ago

yeah, I want to make the build pass again shortly. :)

jipiboily commented 7 years ago

@omricohen while working on making the build pass (#301) I had to resetup Monologue locally, and the migrations worked perfectly fine for me.

What is this PR trying to fix/change exactly? Not 100% clear to me.

Thanks!

jipiboily commented 7 years ago

That's going to be more complicated than I thought. See #301 please. Happy to pay $100 if someone wants to get Monologue back on track.

jipiboily commented 7 years ago

Actually, see https://github.com/jipiboily/monologue/issues/314 instead.

omricohen commented 7 years ago

@jipiboily This PR makes it so that you can rollback a monologue install. The current migrations do not allow for a rollback. Plus, not point in keeping so many migration 'change' files, makes it harder to maintain and understand what is going on.

msevestre commented 1 year ago

I am going to close this PR as it is polluting my Review list and is clearly outdated :)