search

jipiboily / spree_multi_lingual

Spree multi-lingual is a plugin to make multi locale store with Spree possible
BSD 3-Clause "New" or "Revised" License
49 stars 56 forks source link

Something wrong in README.md #16

Closed n5ken closed 11 years ago

n5ken commented 12 years ago

In the installation part, I can't bundle the gem with adding the following code to Gemfile

gem "spree_multi_lingual", :git => "git@github.com:jipiboily/spree_multi_lingual.git"

And it should be

gem 'spree_multi_lingual', :git => 'git://github.com/jipiboily/spree_multi_lingual.git'
n5ken commented 12 years ago

Additional issue, the I18n in the code below should have I lower case

# config/application.rb
config.I18n.fallbacks = true

like this

# config/application.rb
config.i18n.fallbacks = true

otherwise

rake aborted!
undefined method `I18n' for #<Rails::Application::Configuration:0x00000001b125f0>
Davidslv commented 12 years ago

Seems the owner isn't available for a while, I corrected that and also add Option Values to be translated.

jipiboily commented 12 years ago

I will take a look at that "soon".

@Davidslv is your work on your fork or something that could be pulled here?

(sorry for the delay, I was in vacations)

jipiboily commented 12 years ago

Oh, sorry, there is a PR for that...

Davidslv commented 12 years ago

Hi, yes, I think you have all the necessary code in my pull request. In a newer version I also added support for pages (using the gem spree_pages), but I don't think that could be relevant once is not part of the spree core.

jipiboily commented 12 years ago

To have pages managed via Monologue UI? It seems to be an equivalent to spree_static_content, right?

sbounmy commented 11 years ago

readme fixed. thanks and sorry for the delay