search

jipiboily / spree_multi_lingual

Spree multi-lingual is a plugin to make multi locale store with Spree possible
BSD 3-Clause "New" or "Revised" License
49 stars 56 forks source link

Can't drop translation tables #24

Open lcx opened 12 years ago

lcx commented 12 years ago

spree_multi_lingual is using globalize3 0.2.0.beta8 which has a bug when you try to drop the translation tables: https://github.com/svenfuchs/globalize3/blob/v0.2.0/lib/globalize/active_record/migration.rb#L136

which has already been fixed here: https://github.com/svenfuchs/globalize3/commit/7dc900c70a72ea2cbe13e9c32e9cde1d60ba3e0c

any particular reason why still using 0.2.0.beta8? Version 0.2.0 still has this bug!

jipiboily commented 12 years ago

Still using a beta version because it was the latest version last time I updated this extension. That said, if you or someone else want to update it and send a PR that would be much appreciated by the other users of spree_multi_lingual I think.

lcx commented 12 years ago

I tried using the github version which did really work as expected. Seems like I can't specify a git repository in a gemspec file as can be done in a Gemfile. What I did was remove the Version all together (https://github.com/lcx/spree_multi_lingual/commit/5b1c032c8a5876efb7c84a47e40e61363d9ef124 I could send a PR for that so far I can see it works for us. I also had to remove the translation of the permalink but that is in a different commit.

jipiboily commented 12 years ago

It's true that you can't specify a git repo in a gemspec. Removing version would not assure the use of a version 0.2.0+ to everyone unless people are using "bungle update", maybe it would be better to specify the version range that works with spree_multi_lingual?

lcx commented 12 years ago

would have done that if there was a newer version released. Unfortunately the only release version is 0.2.0 which still has the bug. As long as you don't want to drop the tables ... version 0.2.0 works fine. I just had to remove the translations and came across this issue.