search

jipiboily / spree_multi_lingual

Spree multi-lingual is a plugin to make multi locale store with Spree possible
BSD 3-Clause "New" or "Revised" License
49 stars 56 forks source link

Translated Attributes Customization. #46

Open DavideMiozzi opened 10 years ago

DavideMiozzi commented 10 years ago

I added some attributes to my Product model which I'd need to support locales. I'm already using spree_multi_lingual and I tried to take advantage of easy_globalize3_accessors and override in my product_decorator the translated attributes (after creating and running the corresponding migrations). Yet, only the ones defined in spree_multi_lingual get translated. I'll solve this problem by forking the gem and making it suit my requirements, but what about adding the possibility of add/remove the translated attributes of a product?

sbounmy commented 10 years ago

this is a great idea ! to support this I think we should take a closer look at https://github.com/jipiboily/spree_multi_lingual/blob/master/lib/spree_multi_lingual/translates_with_accessors.rb#L29

We should be able to append attributes to translates method I would love to merge this improvement if you can make a pull request ! :+1: