search

jipolanco / PencilArrays.jl

Distributed Julia arrays using the MPI protocol
https://jipolanco.github.io/PencilArrays.jl/dev/
MIT License
60 stars 8 forks source link

Redefine `size` and `length` as global #32

Closed jipolanco closed 2 years ago

jipolanco commented 2 years ago

This PR redefines size(::PencilArray) and length(::PencilArray) so that they return the global array size. This is of course a breaking change.

This seems to be required for PencilArrays to seamlessly work with DifferentialEquations.jl when using adaptive timestepping.

codecov-commenter commented 2 years ago

Codecov Report

Merging #32 (72aad84) into master (3dd4ff4) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   96.92%   96.95%   +0.02%     
==========================================
  Files          17       18       +1     
  Lines         977      984       +7     
==========================================
+ Hits          947      954       +7     
  Misses         30       30
Impacted Files Coverage Δ
src/PencilArrays.jl 100.00% <ø> (ø)
src/Pencils/Pencils.jl 100.00% <100.00%> (ø)
src/Transpositions/Transpositions.jl 97.81% <100.00%> (ø)
src/arrays.jl 94.56% <100.00%> (-0.18%) :arrow_down:
src/multiarrays.jl 100.00% <100.00%> (ø)
src/size.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dd4ff4...72aad84. Read the comment docs.