search

jipolanco / PencilArrays.jl

Distributed Julia arrays using the MPI protocol
https://jipolanco.github.io/PencilArrays.jl/dev/
MIT License
60 stars 8 forks source link

use VersionParsing to parse non-semver versions #36

Closed stevengj closed 2 years ago

stevengj commented 2 years ago

I noticed that you were using the VersionNumber constructor to parse the MPIIO version string, which may not be in semver format; you might want to use VersionParsing instead.

codecov-commenter commented 2 years ago

Codecov Report

Merging #36 (87c4be3) into master (3507807) will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   96.94%   97.03%   +0.08%     
==========================================
  Files          17       17              
  Lines         982      978       -4     
==========================================
- Hits          952      949       -3     
+ Misses         30       29       -1
Impacted Files Coverage Δ
src/PencilIO/mpi_io.jl 96.20% <100.00%> (+0.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3507807...87c4be3. Read the comment docs.

jipolanco commented 2 years ago

Great, thank you!