search

jipolanco / PencilArrays.jl

Distributed Julia arrays using the MPI protocol
https://jipolanco.github.io/PencilArrays.jl/dev/
MIT License
60 stars 8 forks source link

Define `pairs` for local grids #67

Closed jipolanco closed 2 years ago

jipolanco commented 2 years ago

This overrides the default definition of pairs for LocalRectilinearGrid. The new definition is basically the same as that for AbstractArray.

These changes seem to improve performance when iterating over local grids using pairs.

codecov-commenter commented 2 years ago

Codecov Report

Merging #67 (b233ee4) into master (ed712ff) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   96.98%   96.95%   -0.04%     
==========================================
  Files          22       22              
  Lines        1228     1214      -14     
==========================================
- Hits         1191     1177      -14     
  Misses         37       37
Impacted Files Coverage Δ
src/LocalGrids/rectilinear.jl 97.43% <100.00%> (+0.06%) :arrow_up:
src/PencilIO/hdf5.jl 93.33% <0.00%> (-0.11%) :arrow_down:
src/PencilIO/mpi_io.jl 95.90% <0.00%> (-0.08%) :arrow_down:
src/Pencils/MPITopologies.jl 97.40% <0.00%> (-0.07%) :arrow_down:
src/Transpositions/Transpositions.jl 98.08% <0.00%> (-0.03%) :arrow_down:
src/Pencils/Pencils.jl 99.13% <0.00%> (-0.02%) :arrow_down:
src/gather.jl 100.00% <0.00%> (ø)
src/Pencils/data_ranges.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed712ff...b233ee4. Read the comment docs.