search

jipolanco / PencilFFTs.jl

Fast Fourier transforms of MPI-distributed Julia arrays
https://jipolanco.github.io/PencilFFTs.jl/dev/
MIT License
77 stars 7 forks source link

Remove element type information from Pencil #16

Closed jipolanco closed 4 years ago

jipolanco commented 4 years ago

There is no reason why a Pencil configuration should include element type information.

For compatibility, an element type will still be encoded into Pencil for the next few versions, but eltype(::Pencil) will display a deprecation warning.

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will decrease coverage by 0.26%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   96.14%   95.88%   -0.27%     
==========================================
  Files          23       23              
  Lines         934      947      +13     
==========================================
+ Hits          898      908      +10     
- Misses         36       39       +3
Impacted Files Coverage Δ
src/PencilIO/hdf5.jl 89.47% <ø> (ø)
src/Pencils/Pencils.jl 85.00% <25.00%> (-7.11%) :arrow_down:
src/PencilArrays/arrays.jl 95.95% <100.00%> (-0.05%) :arrow_down:
src/PencilArrays/multiarrays.jl 100.00% <100.00%> (ø)
src/operations.jl 100.00% <100.00%> (ø)
src/pencil_plans.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 252939c...5b4b3c6. Read the comment docs.