search

jippi / vault-php-sdk

Vault PHP SDK, inspired by sensio consul sdk
MIT License
54 stars 35 forks source link

protected properties: services and client #18

Closed sanchescom closed 5 years ago

sanchescom commented 5 years ago

Would be better to make these properties protected. I don't want to fork it but and at the same time, I need to add some services. The best way to extend ServiceFactory but it useless all properties are private.

jippi commented 5 years ago

Thanks, I've cut https://github.com/jippi/vault-php-sdk/releases/tag/3.0.0 from this PR