jippi / vault-php-sdk

Vault PHP SDK, inspired by sensio consul sdk
MIT License
54 stars 35 forks source link

more defensive than just using NullLogger? #20

Open drouu opened 4 years ago

drouu commented 4 years ago

i understand the reasoning behind using NullLogger in Client. but in practice, the value returned by $response->getBody() can be quite large, and duplicating it for debug logging (line 100) when its just going to get blackholed is a bit wasteful and can trigger an out-of-memory error in cases where you thought your application had enough.