search

jiptool / jip

Java dependency management for Jython
http://pypi.python.org/pypi/jip/
Other
59 stars 15 forks source link

Use bumpversion #45

Closed baztian closed 7 years ago

baztian commented 7 years ago

This PR makes it possible to just call bumpversion patch (or bumpversion minor, bumpversion major) to update versions, the changelog section of the README and add tags. As a last step git push --tags is required to have a new release. This would drop support for .devX versions. It might be possible with bumpversion. I haven't checked as I don't see a need for that.

@jiptool what do you think?

baztian commented 7 years ago

I forgot to mention a requirement:

pip install bumpversion
sunng87 commented 7 years ago

LGTM. Every time I prepare a release I was thinking about such a tool. I'm OK with dropping dev version.

baztian commented 7 years ago

@sunng87, while I'm at it. What is the purpose of the JIP_VERSION constant in init.py? I guess it sits there to be referenced by setup.py. Correct? I would prefer to have setup.py also under control of bumpversion and remove JIP_VERSION completely. That has the advantage of not having cyclic dependencies from importing init.py in setup.py if you import 3rd party libs that setup.py has not yet been installed. Would that be ok?

sunng87 commented 7 years ago

@baztian I think having JIP_VERSION in the source is for jip version command. Does python have more elegant way to deal with that?

baztian commented 7 years ago

__version__ is Python standard. Instead of accessing JIP_VERSION we could access just version.

baztian commented 7 years ago

Rebased onto master

baztian commented 7 years ago

Built a new release using

bumpversion patch
git push --follow-tags upstream
sunng87 commented 7 years ago

good job!