search

jira-node / node-jira-client

A Node.js wrapper for the Jira REST API
https://jira-node.github.io/
MIT License
449 stars 168 forks source link

Moving from request to axios #348

Open LunaticMuch opened 1 year ago

LunaticMuch commented 1 year ago

Current HTTP client is old, any appetite @pioug if I help moving to axios maybe?

Seth10001 commented 1 year ago

Are there any features that axios gives us that are currently not implemented with postman-request?

LunaticMuch commented 1 year ago

Are there any features that axios gives us that are currently not implemented with postman-request?

Per se no, but why using a client with many and old dependencies, including deprecated ones, when other more updated clients can do the same?

Got, fetch and axios can do the same and are more maintained and widely used.

axios has 3 dependencies, all updated. postman-request has 21, few of them completely deprecated like har-validator

Seth10001 commented 1 year ago

That makes sense to me. We recently switched to postman-request since its a fork of the original request library (#331).

I've used axios a lot and believe it would be a good move. My biggest concern is I'm not sure how different the behavior is from request. It'd be best to maintain as much backwards compatiablity as possible.

Feel free to give it a shot, just make sure to test it heavily with a real Jira API. I'm not sure our unit tests are sufficient proof for a change like this.

LunaticMuch commented 1 year ago

I will test against my company JIRA and also using a brand-new cloud JIRA instance which I just provisioned.

Seth10001 commented 1 year ago

It might be a good idea to setup a free jira organization and create some integration tests against it

nitk-shashankshah commented 6 months ago

Hi, We are also using Jira Client which uses request module which further uses an old version of tough-cookie module (which has security vulnderabilities). Our Security Scanner is flagging it therefore can we know when this issue will be fixed and new version of jira-client will be available?