jirentabu / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

Code review request #2

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:

Additions/Fixes

When reviewing my code changes, please focus on:

-fix: Ambiguity of WTL::CString and ATL::CString. I Replaced <atlmisc.h>
with <atlstr.h> and <atltypes.h> 
      where needed (in many places).

-add: C++ exception handlers (CrashHandler.cpp).
      Some handlers are installed on per-process basis (add
SetProcessCPPExceptionHandlers()\UnSetProcessCPPExceptionHandlers())
      and some on per-thread basis
(SetThreadThreadCPPExceptionHandlers()\UnSetThreadThreadCPPExceptionHandlers()).

-add: Two new exported functions: crInstallToCurrentThread() and
crUninstallFromCurrentThread().
      These functions install/uninstall C++ exceptions on per-thread basis.
      'cr' prefix means 'crashrpt'. I offer to add 'cr' to all new
functions that we create for crashprt.       

-add: <MiscInfo> tag in XML file. The tag contains UserEmail,
ProblemDescription and SystemTime attributes.
      This is to make more convenient to analyse crash reports on
developer's side.

-add: Modified CRASHRPT_EXPORTS definition (I had some problems with it). 
      Added CRASHRPT_EXPORTS preprocessor definition in project settings.
This way is recommended in MSDN.

-fix: Replaced LPCSTR with LPCTSTR everywhere. This is to correctly support
UNICODE.

-add: Window icon (maindlg.h: line 119). Set last param to FALSE to load
small icon.

-fix: Last character in email becomes lost (maindlg.h: line 190). I added
+1 to length of buffer.

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by zexspect...@gmail.com on 13 May 2009 at 12:30

GoogleCodeExporter commented 9 years ago

Original comment by zexspect...@gmail.com on 16 Jul 2009 at 2:54