jirentabu / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

Added file changes (renamed, moved, removed, etc.) within a client program's running session. #219

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Call crAddFile2(...) to register some file path into the Error Report.
2. Call crGenerateErrorReport(...) to manually generate an error report.
3. Make files added in Step-1 changes (rename, move, remove, etc.)
& call crAddFile2(...) to register these files.

4. Call crGenerateErrorReport(...) to manually generate an error report again.
OR
Do a crash on program to automatically generate a crash report.

What is the expected output? What do you see instead?
Together with files added in Step-3, The old file paths added in Step-1 are 
still added into crash report (though there are no physical files of the paths 
in computer driver).

What version of CrashRpt are you using?
_v.1.4.2_r1609

What is your version of Visual Studio?
VS 2010

What is your version of Windows operating system?
Windows OS 8

Please provide any additional information below.
I think,
NOT ONLY in int CCrashHandler::AddFile(...), check for file physically existing.
BUT ALSO in ERIFileItem::GetFileInfo(...),called in 
CDetailDlg::FillFileItemList() to show the file list in Error Report Detail 
dialogs.

=> There should be a check on whether at the up-to-date moment, the file stills 
exists or not.

P/S: Though the file is empty displayed in Error Report Details Dialog, it is 
not zipped or sent for the physical at the old path does not exist.

In, CErrorReportSender::CollectSingleFile(...), called in 
CErrorReportSender::CollectCrashFiles(), the check already does the check in 
order to copy the CR_AF_MAKE_FILE_COPY file from its original source path to 
Error Report Folder, which is then attached in Sent Mail.

Original issue reported on code.google.com by tadhuski...@gmail.com on 4 Oct 2013 at 4:15

Attachments:

GoogleCodeExporter commented 9 years ago
I've fixed this in truck. Please check if you have time.

Original comment by zexspect...@gmail.com on 5 Oct 2013 at 5:47

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r1635.

Original comment by zexspect...@gmail.com on 5 Oct 2013 at 5:47