jirentabu / crashrpt

Automatically exported from code.google.com/p/crashrpt
0 stars 0 forks source link

latest distribution missing gzio.c #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download the latest distribution
2. Try and build it.
3. It worked for me on Release, but not Debug, I was getting linker errors
on gzclose. When I went looking for gzclose I noticed gzio.c (the file that
contains the body of gzclose was missing.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
CrashRpt 1.1.3_r416 on Windows

Please provide any additional information below.

downloading the zlib 1.2.3 from zlib.net and putting gzio.c into the
directory made everything work smoothly.

- BTW... Great tool.

Original issue reported on code.google.com by Chris.Bi...@gmail.com on 18 Sep 2009 at 9:11

GoogleCodeExporter commented 9 years ago
I couldn't reporoduce this behavior on any Visual Studio neither in Debug nor in
Release configuration. gzio.c is not a part of crashrpt distribution, and 
everthing
compiles well without it if you follow the steps provided in documentation for
compiling the library.

1. What Visual Studio are you using with what SP? 
2. Do you follow the compiling recomendations provided in the documentation?

Original comment by zexspect...@gmail.com on 19 Sep 2009 at 11:17

GoogleCodeExporter commented 9 years ago
1. Visual Studio 2003 SP1, 2008 & 2010
2. Yes, I have read through the documentation. That was the first place I 
looked.

I looked into this more.

The reason this is happening is because you include minigzip.c in your 
distribution.
Even though you're not using the gz functionality unless the compiler strips it 
as
'dead code' it will still attempt to link it. And in order to successfully link
minigzip.c you need gzopen, and gzclose from gzio.c.

Again I know you're not actually using this functionality, but since the 
minigzip.c
file is included in your distribution you should also include gzio.c. Otherwise 
the
compiler may not successfully complete the build.

The Visual Studio compilers tend to behave like dogs that will eat whatever you 
put
in front of them.

Again, my complements on your library it is very well written.

Original comment by Chris.Bi...@gmail.com on 21 Sep 2009 at 5:10

GoogleCodeExporter commented 9 years ago
I'm confused why this can't be reporduced on my machine... Anyway, I'll include
gzio.c into the next build.

Original comment by zexspect...@gmail.com on 22 Sep 2009 at 2:15

GoogleCodeExporter commented 9 years ago
This issue is fixed in v1.2.0

Original comment by zexspect...@gmail.com on 7 Nov 2009 at 2:59