SVN/package file encoding strangeness

[GoogleCodeExporter]

In version 1.2.8

It seems that the following files are encoded in UCS-2 Little Endian instead of 
ANSI:
  - tests\Tests.cpp
  - tests\CrashRptProbeAPITests.cpp
  - reporting\crashrpttest\CrashRptTest.cpp

Futhermore, you have some files that have inconsistent line end, a mix of CRLF 
and LF. I have wrote a small unix script to detect them (note that previous 
files may be in the same state, but the convertion to ANSI should correct them)

./reporting/crashsender/ErrorReportSender.cpp (lines:1911|CRLF:1890)
./reporting/crashsender/FilePreviewCtrl.cpp (lines:1560|CRLF:1556)
./reporting/crashsender/CrashInfoReader.cpp (lines:867|CRLF:847)
./processing/crashrptprobe/CrashDescReader.cpp (lines:457|CRLF:455)
./processing/crprober/main.cpp (lines:956|CRLF:953)

Number of files examinated: 442
Number of CRLF: 378
Number of LF: 115
Number of files inconsistent: 5

This is a small issue, which is masked by Visual Sutdio, but it can be annoying 
anyway.

Thank for your great job!

Lionel Molinier

Original issue reported on code.google.com by lionel.m...@gmail.com on 24 Feb 2011 at 9:30

[GoogleCodeExporter]

The files tests\Tests.cpp, tests\CrashRptProbeAPITests.cpp and  
reporting\crashrpttest\CrashRptTest.cpp are UTF-8 encoded. This was done 
because they contain Chineese characters (ANSI is not suitable). I didn't 
convert the rest of files because it is unneded work, everything seems to work 
fine.

How a mix of CRLF and LF may be annying? 

Original comment by zexspect...@gmail.com on 24 Feb 2011 at 3:25

• Changed state: Reviewed
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Ok for the three files, I thought it was a mistake.

The mix in the same file of CRLF & LF, is not a big problem with Visual since 
it is understanding it well.
Actually, I've been faced with a problem commiting your last version as 
third-parts in my repository which was not accepting this inconsistency. I 
dealt with that, but I had think that you would appreciate to be informed so 
that you could maintain a coherent source code in your repository.
I understand that you may not want to correct that since it is not a big issue.

Best regards,
Lionel Molinier

Original comment by lionel.m...@gmail.com on 25 Feb 2011 at 9:37

[GoogleCodeExporter]

I'll fix the inconsistent CRLF & LF issue in the next release. I appreciate 
your feedback, thank you.

Original comment by zexspect...@gmail.com on 25 Feb 2011 at 1:24

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in 1.2.9.

Original comment by zexspect...@gmail.com on 2 Apr 2011 at 7:00

• Changed state: Fixed