CrashSender cannot properly send old reports (with smtp)

[GoogleCodeExporter]

1. Create several (> 1) crashes
2. When reminded, try to send them through smtp
I tested the 1.2.9_r1150 download.

I have also tracked down the reasons, two small bugs:

1)
In CrashInfoReader.cpp, there is a bug in the function CCrashInfoReader::Init

  …
  ErrorReportInfo eri2;
  eri.m_sErrorReportDirName = sErrorReportDirName;
  if(0==ParseCrashDescription(sFileName, TRUE, eri2))
  {          
    eri.m_uTotalSize = GetUncompressedReportSize(eri2);
    m_Reports.push_back(eri2);

There is a mixup between eri and eri2. The bug seems fixed in the current trunk 
of the svn.

2)
In ErrorReportSender.cpp, there is a bug in SendOverSMTP:

  …
  // We should have aline here like this:
  // m_EmailMsg.m_aAttachments.clear();
  m_EmailMsg.m_aAttachments.insert(m_sZipName);

The commented line deleting the attachments is missing. When sending several 
error reports the second mail tries to resend the .zip and .md5 file of the 
first and so on, thus failing.

Original issue reported on code.google.com by asch...@gwdg.de on 13 May 2011 at 2:33

[GoogleCodeExporter]

Original comment by zexspect...@gmail.com on 13 May 2011 at 3:10

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in v.1.2.10.

Original comment by zexspect...@gmail.com on 22 May 2011 at 10:49

• Changed state: Fixed