search

jirihybek / unity-websocket-webgl

Hybrid WebSocket implementation for Unity 3D with support of native and browser client.
Other
248 stars 61 forks source link

Uncaught exception when WebSocketSend called after WS closed #3

Open austinkelleher opened 5 years ago

austinkelleher commented 5 years ago

An uncaught exception will occur if WebSocketSend is called after the ws property on the instance has already been deleted here: https://github.com/jirihybek/unity-websocket-webgl/blob/master/Plugins/WebSocket.jslib#L205

Uncaught TypeError: Cannot read property 'readyState' of undefined

This is because the WebSocketSend method only checks for null, but in this case the value would be undefined here: https://github.com/jirihybek/unity-websocket-webgl/blob/master/Plugins/WebSocket.jslib#L258

I will have a PR with the fix momentarily.

XtroTheArctic commented 3 years ago

This PR fixed my problem. Thank you very much.