search

jiripospisil / chrome-ext-downloader

A simple utility for downloading Chrome extensions
51 stars 7 forks source link

Unable to download the CRX file #2

Closed stewartlord closed 7 years ago

stewartlord commented 7 years ago

The finalURL is not composed correctly on Mac. Maybe util.format() behaves differently on Mac, but the result is definitely not what you want. I suspect it has to do with the % encoded characters. Simple string concatenation works

jiripospisil commented 7 years ago

Huh, could you post the URL of the extension?

stewartlord commented 7 years ago

Sure! https://chrome.google.com/webstore/detail/grammarly-for-chrome/kbfnbcaeplbcioakkpcpgfkobkghlhen This worked fine on Linux, but on Mac the URL was mangled.

jiripospisil commented 7 years ago

I don't think it has anything to do with the platform but rather the Node.js version. I can download the extension just fine with Node.js 7.9 but it indeed fails with 8.1.2. What version are you running? Nevertheless, I will look into it more over the weekend.

stewartlord commented 7 years ago

That makes sense. I am running 8.1.0 (on my mac). Thanks!

jiripospisil commented 7 years ago

It works again with Node.js 8.1.3. I think it was fixed by https://github.com/nodejs/node/pull/13674. Thank you for the bug report!

stewartlord commented 7 years ago

Thanks for following-up @jiripospisil :+1: