Please find attached a pull request proposal for you. ;)
i've added an UMIL installer and did a number of other edits. now the module configuration is automated.
it now passes mpv with a few notices :
[ NOTICE ] Please note that all checks are done by an automated tool. In some cases a FAIL/WARNING can be valid/allowed usage of a function.
[ FAIL ] SFNC-0.4.1/readme.md: File has been detected as non-binary while the extension IS binary. Checking for PHP code for security reasons.
[ FAIL ] SFNC-0.4.1/readme.md: A define for IN_PHPBB is missing or there is no check for if IN_PHPBB is set.
[ NOTICE ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using require_once() at line 629:
require_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx);
Using include with a function/class_exists check is preferred over include/require _once
[ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 66:
$cache->_write('sfncfeed' . md5($this->url), $this->items, time());
MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid.
[ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 82:
return $cache->_read('sfncfeed' . md5($this->url));
MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid.
[ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 735:
'message_md5' => md5($message),
MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid.
[ NOTICE ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using require_once() at line 629:
require_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx);
Using include with a function/class_exists check is preferred over include/require _once
[ FAIL ] SFNC-0.4.1/install.xml: Your MOD version (0.4.1) is unstable. It should be higher
hi jirismika,
Please find attached a pull request proposal for you. ;)
i've added an UMIL installer and did a number of other edits. now the module configuration is automated.
it now passes mpv with a few notices :
[ NOTICE ] Please note that all checks are done by an automated tool. In some cases a FAIL/WARNING can be valid/allowed usage of a function. [ FAIL ] SFNC-0.4.1/readme.md: File has been detected as non-binary while the extension IS binary. Checking for PHP code for security reasons. [ FAIL ] SFNC-0.4.1/readme.md: A define for IN_PHPBB is missing or there is no check for if IN_PHPBB is set. [ NOTICE ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using require_once() at line 629: require_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx); Using include with a function/class_exists check is preferred over include/require _once [ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 66: $cache->_write('sfncfeed' . md5($this->url), $this->items, time()); MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid. [ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 82: return $cache->_read('sfncfeed' . md5($this->url)); MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid. [ WARNING ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using md5() at line 735: 'message_md5' => md5($message), MD5 should not be used for anything related to passwords. Other usage of MD5 is probably valid. [ NOTICE ] SFNC-0.4.1/root/includes/mods/sfnc/sfnc.class.php: Using require_once() at line 629: require_once($phpbb_root_path . 'includes/functions_posting.' . $phpEx); Using include with a function/class_exists check is preferred over include/require _once [ FAIL ] SFNC-0.4.1/install.xml: Your MOD version (0.4.1) is unstable. It should be higher
cheers, Andreas