Fix error handling as well as add new command

jirka-h / haveged

Entropy daemon ![Continuous Integration](https://github.com/jirka-h/haveged/workflows/Continuous%20Integration/badge.svg)

GNU General Public License v3.0

271 stars 34 forks source link

Fix error handling as well as add new command #52

Closed bitstreamout closed 3 years ago

bitstreamout commented 3 years ago

for closing the communication socket.

Based on report and pull request of Michal Suchanek msuchanek@suse.de

Signed-off-by: Werner Fink werner@suse.de

jirka-h commented 3 years ago

This PR conflicts with #50 (which I have initially merged and reverted after I have realized it conflicts with this PR).

I don't have any strong preference. Could you please discuss together and let me know the decision?

I see these options

I can merge either PR#50 or PR#52
a new PR which combines PR#50 and PR#52 together

Thanks Jirka

hramrach commented 3 years ago

Please merge this one. While I think using the ASCII ACK/NAK for return values is way too limiting this is the current state of the code so there will be no compatibility issue when upgrading.

jirka-h commented 3 years ago

I agree. Merging.