jiro4989 / setup-nim-action

Set up your GitHub Actions workflow with a specific version of Nim
MIT License
104 stars 14 forks source link

Fails to select version when using particular commit #305

Closed yyoncho closed 1 year ago

yyoncho commented 1 year ago

Describe the bug

choosenim supports using commit id, e. g. #branch-name, #commit-id. It seems like setup-nim-action fails to do so.

To Reproduce


on:
  push:
  pull_request:
  schedule:
  - cron: "0 19 * * *"

jobs:
  test:
    strategy:
      matrix:
        os:
          - ubuntu-latest
        nimversion:
          - "#version-1-6"
    name: ${{ matrix.os }} - ${{ matrix.nimversion }}
    runs-on: ${{ matrix.os }}
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    steps:
      - uses: actions/checkout@v3
      - uses: jiro4989/setup-nim-action@v1.4.1
        with:
          nim-version: ${{ matrix.nimversion }}
          yes: true
      - name: Install Mercurial on macOS
        run: nim --version

Expected behavior

the correct version is installed properly

Screenshots or Logs

https://github.com/yyoncho/langserver/actions/runs/4045771119/jobs/6957691462

Additional context

-

jiro4989 commented 1 year ago

@yyoncho I Fixed it. https://github.com/jiro4989/setup-nim-action/releases/tag/v1.4.3

yyoncho commented 1 year ago

Thank you!