search

jiru / kakaodecrypt

Decrypt chat history from the local database of Kakaotalk’s Android app
Do What The F*ck You Want To Public License
64 stars 26 forks source link

Add support for encoding type 27 #5

Closed 71 closed 4 years ago

jiru commented 4 years ago

Thank you for your contribution. Could you also add a test case for encoding type 27 in method testDecryptMessage in kakaodecrypt.test.py?

71 commented 4 years ago

I thought about adding a test case, but don't know how exactly. If I use one of the messages I decrypted myself, aren't I essentially leaking my friend's or my ID to the world?

Otherwise I could create a dummy test case like this, but I wasn't sure it was good enough.

jiru commented 4 years ago

If I use one of the messages I decrypted myself, aren't I essentially leaking my friend's or my ID to the world?

Yes. But that’s the only way we can be sure it’s working. I don’t know to what extent the ID is personal data or wether it can be used by a third party somehow, so it may or may not be a problem. It’s okay for me to merge your PR without a test case, but it would be better if you can add one. Maybe it’s possible to use a message of a well-known account like a translation bot?

71 commented 4 years ago

For now all the messages I have with encoding 27 are from real people, so I'd rather not leak that :/