search

jirutka / rake-jekyll

Rake tasks for Jekyll as a gem.
MIT License
30 stars 3 forks source link

jekyll build failure does not cause rake task to fail #3

Closed travi closed 9 years ago

travi commented 9 years ago

The system call does not use the exit code to fail the rake task.

I was able to work around this issue with a simple change, but thought you may want to handle this in the gem itself.

razor-x commented 9 years ago

I noticed this issue a bit after my original post on deploying this way. Anyway I switched from using the system call to the sh method which seems to be the preferred way for rake. The sh method should fail the rake task correctly and give the correct exit code.

See https://gist.github.com/razor-x/8166421

jirutka commented 9 years ago

@razor-x I know about the sh method, but the problem is that this method is defined by rake and it's not available inside a lambda IIRC. That's why I used system instead.