search

jirutka / setup-alpine

Easily use Alpine Linux on GitHub Actions, with support for QEMU user emulator
MIT License
93 stars 14 forks source link

Update README.adoc #13

Closed LinuxUserGD closed 6 months ago

LinuxUserGD commented 6 months ago

Fixes invalid unicode characters reported by Gitea/Forgejo (see go-gitea/gitea#23682)

screenshot

jirutka commented 6 months ago

Are you trolling me? These are completely valid Unicode characters.

LinuxUserGD commented 6 months ago

Are you trolling me? These are completely valid Unicode characters.

Sorry for the typo PR, according to online ASCII validators it’s instead of it's is invalid though. https://onlinetools.com/ascii/validate-ascii

qemu

jirutka commented 6 months ago

Sorry for the typo PR

If you mean typo as typography, then your PR is literally degrading the typography in this document.

according to online ASCII validators it’s instead of it's is invalid though.

It’s not 70s anymore, we live in the 21st century, where Unicode is the standard. So I’m using proper Unicode punctuation characters (e.g. U+2019) instead of their poor ASCII replacements.

If you don’t understand what I’m saying, then I’m sorry, you need to learn something about typography and Unicode.

LinuxUserGD commented 6 months ago

It’s not 70s anymore, we live in the 21st century, where Unicode is the standard. So I’m using proper Unicode punctuation characters (e.g. U+2019) instead of their poor ASCII replacements.

According to the AsciiDoc documentation, the ASCII substitution for the typographic apostrophe is ’ which would be displayed correctly as well (see https://github.com/LinuxUserGD/setup-alpine/commit/57078161374d10b9e0130ec14a2378bb589c71c3 for reference).