search

jirwin / burrow_exporter

Prometheus exporter for burrow
Apache License 2.0
78 stars 68 forks source link

update to v3 api #10

Closed cohadar closed 6 years ago

cohadar commented 6 years ago

It makes sure output file is named "burrow-exporter". It is the same as calling "go build burrow-exporter.go" only more standard

ercliou-zz commented 6 years ago

One small detail: I don't think this metric "maxoffset" exists anymore: https://github.com/jirwin/burrow_exporter/blob/master/burrow_exporter/exporter.go#L54

I haven't used v2, not sure what this metric means, but the Burrow wiki for v3 doesn't mention this metric. Also I've just tested on Burrow v3, it's not exposing this field.

(commenting this on another PR too, not sure which will be the final one)

jirwin commented 6 years ago

Closing this since I merged #12. Thanks for submitting this!