search

jirwin / burrow_exporter

Prometheus exporter for burrow
Apache License 2.0
78 stars 68 forks source link

fix(KafkaConsumerPartitionLag): Use proper current lag #27

Closed xiu closed 5 years ago

xiu commented 5 years ago

Before this fix, the latest committed lag was used for the metric, it now uses the current lag on the partition.

Fixes #26

sruslanas commented 5 years ago

+1 when this would be merged?

byteSamurai commented 5 years ago

@jirwin Could you merge this or deny with reason please?

kojamam commented 5 years ago

+1 before this fix, total_lag is not equal to sum(partition_lag).

but, Burrow's totallag is equal to sum(partition.current_lag) It is calculated here on Burrow source code.

Would you merge this PR? Please.