jisaacks / GitGutter

A Sublime Text 2/3 plugin to see git diff in gutter
MIT License
3.87k stars 224 forks source link

GitGutter isn't working on OSX Sublime Text 3 #152

Closed gespinha closed 7 years ago

gespinha commented 10 years ago

Hi there,

I have installed and reinstalled various times GitGutter and it still doesn't work. I have tried verifying if I am using git and it is on. What should I do to diagnose my problem?

Thanks

jisaacks commented 10 years ago

Did you try setting the git path?

On Thursday, March 13, 2014, Goncalo Espinha notifications@github.com wrote:

Hi there,

I have installed and reinstalled various times GitGutter and it still doesn't work. I have tried verifying if I am using git and it is on. What should I do to diagnose my problem?

Thanks

Reply to this email directly or view it on GitHubhttps://github.com/jisaacks/GitGutter/issues/152 .

gespinha commented 10 years ago

Yes, it did it now, but it didn't work. My git path returned as "/usr/bin/git" does this make any sense to you?

josue commented 10 years ago

I also cannot install the package via the Sublime package manager, however it did work when i tried via commandline and git cloning.

Here's my Sublime console output if it helps:

ignored packages updated to: [Vintage, GitGutter]
Exception in thread Thread-18:
Traceback (most recent call last):
  File "X/threading.py", line 639, in _bootstrap_inner
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/package_installer.py", line 241, in run
    self.result = self.manager.install_package(self.package)
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/package_manager.py", line 480, in install_package
    package_bytes = download_manager.fetch(url, 'Error downloading package.')
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/download_manager.py", line 180, in fetch
    return self.downloader.download(url, error_message, timeout, 3, prefer_cached)
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/downloaders/urllib_downloader.py", line 111, in download
    http_file = self.opener.open(request, timeout=timeout)
  File "X/urllib/request.py", line 473, in open
  File "X/urllib/request.py", line 491, in _open
  File "X/urllib/request.py", line 451, in _call_chain
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/validating_https_handler.py", line 44, in https_open
    return self.do_open(http_class_wrapper, req)
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/persistent_handler.py", line 94, in do_open
    if r.is_keep_alive():
  File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/debuggable_http_response.py", line 58, in is_keep_alive
    if connection.lower() == 'keep-alive':
AttributeError: 'NoneType' object has no attribute 'lower'
jisaacks commented 10 years ago

Open your user settings and remove git gutter from the ignored packages.

On Thursday, March 13, 2014, Josue Rodriguez notifications@github.com wrote:

I also cannot install the package via the Sublime package manager, however it did work when i tried via commandline and git cloning.

Here's my Sublime console output if it helps:

ignored packages updated to: [Vintage, GitGutter] Exception in thread Thread-18: Traceback (most recent call last): File "X/threading.py", line 639, in _bootstrap_inner File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/package_installer.py", line 241, in run self.result = self.manager.install_package(self.package) File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/package_manager.py", line 480, in install_package package_bytes = download_manager.fetch(url, 'Error downloading package.') File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/download_manager.py", line 180, in fetch return self.downloader.download(url, error_message, timeout, 3, prefer_cached) File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/downloaders/urllib_downloader.py", line 111, in download http_file = self.opener.open(request, timeout=timeout) File "X/urllib/request.py", line 473, in open File "X/urllib/request.py", line 491, in _open File "X/urllib/request.py", line 451, in _call_chain File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/validating_https_handler.py", line 44, in https_open return self.do_open(http_class_wrapper, req) File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/persistent_handler.py", line 94, in do_open if r.is_keep_alive(): File "/Users/user/Library/Application Support/Sublime Text 3/Packages/Package Control/package_control/http/debuggable_http_response.py", line 58, in is_keep_alive if connection.lower() == 'keep-alive': AttributeError: 'NoneType' object has no attribute 'lower'

Reply to this email directly or view it on GitHubhttps://github.com/jisaacks/GitGutter/issues/152#issuecomment-37607540 .

gespinha commented 10 years ago

@jisaacks I have verified my User Settings and GitGutter isn't in the "ignored packages". @josue How do I install this via commandline and git cloning?

jisaacks commented 10 years ago

Have you checked both user and default? Because the output you pasted said it is.

On Friday, March 14, 2014, Goncalo Espinha notifications@github.com wrote:

@jisaacks https://github.com/jisaacks I have verified my User Settings and GitGutter isn't in the "ignored packages".

Reply to this email directly or view it on GitHubhttps://github.com/jisaacks/GitGutter/issues/152#issuecomment-37637173 .

gespinha commented 10 years ago

@jisaacks I have checked both and the values are the same:

"ignored_packages":["Vintage"]

josue commented 10 years ago

I have verified my User Settings and GitGutter isn't in the "ignored packages".

@Gespinha see instructions for Installation > OSX

jisaacks commented 10 years ago

Ahh, I was responding via email and I didn't notice I was talking to 2 different people. It was @josue that had the output about the ignored packages.

gespinha commented 10 years ago

@jisaacks oh, no problem. @josue I have tried installing via commandline and still doesn't work

Any other way I can diagnose the problem? How can I see the output?

jisaacks commented 10 years ago

@Gespinha Have you installed via package control or git clone?

Also, did you check the console ctrl + ` for errors?

gespinha commented 10 years ago

GitGutter is not creating a folder for its files in my packages folder. I guess that is the reason why I am getting an error like this, is it not?

FileNotFoundError: [Errno 2] No such file or directory: '/Users/myusername/Library/Application Support/Sublime Text 3/Packages/GitGutter/view_collection.py'

Because I have checked and I have no folder named "GitGutter"

jisaacks commented 10 years ago

Are you saying that the path:

/Users/myusername/Library/Application Support/Sublime Text 3/Packages/GitGutter

Does not exist for you?

I am a little confused, because if git gutter is not there, then I do not know what would be looking for the view_collection.py file.

gespinha commented 10 years ago

Yes, I install GitGutter and the folder doesn't exist. The folder called "GitGutter".

jisaacks commented 10 years ago

I assuming you have installed via package control? Package control has a command called list packages check it to see if it lists git gutter. If not, make sure you have the latest version of package control and try again. If you have the latest version of package control, and after you install via package control, it does not list git gutter when you ask it to list the installed packages - then install via git clone.

jisaacks commented 10 years ago

Oh you said you have also tried installing via command line and it didn't work. Can you please explain step by step what you did, and what happened.

I am trying to determine if you just do not have it installed (which is sounds like) or if it is just not working.

gespinha commented 10 years ago

I have git and latest version of Package Control installed. I have tried installing vie package control or git cloning.

I'm just installing and restarting sublime text everytime.

gespinha commented 10 years ago

I have tried disabling every package I have besides GitGutter and still doesn't work

jisaacks commented 10 years ago

OK when you tried git cloning, what directory did you do it in? Did the repo actually get cloned?

gespinha commented 10 years ago

Yes, I've cloned it and the repo is there, so it is cloning. The package still doesn't work though

jisaacks commented 10 years ago

You also get no errors?

Try this:

Add the following line just under the run method in git_gutter.py:

sublime.message_dialog("git gutter is running")

Then on your sublime text console (hit keys ctrl+` to open it) enter the command:

window.run_command("git_gutter")

Do you get a message dialog?

gespinha commented 10 years ago

Strange, I just noticed the package is working for the git_gutter.py file. And as I inserted the first line in under the run, the alert sign just popped out.

What now?

jisaacks commented 10 years ago

So when you are editing the GitGutter package, GitGutter works as normal?

If so, is it just the 1 repo that git gutter is not working in? Have you tried other repos?

gespinha commented 10 years ago

Yes, I am using other packages and I tried to edit them too, but realised it only works for GitGutter's repo

jmromer commented 10 years ago

I'm having this same issue, oddly enough. it works fine on one user account, but on this new one that I set up, GitGutter won't start and doesn't respond to window.run_command("git_gutter"). I have a fresh install of Sublime Text on this account...I'll poke around and see if I can find what might be going on.

jmromer commented 10 years ago

When I uninstall and reinstall GitGutter, it shows in when I List Packages in the command palette, yet there's no GitGutter directory under Packages, only a settings file for GitGutter under Installed Packages. And the console has the following from the installation:

ignored packages updated to: [Markdown, Vintage, GitGutter]
found 1 files for base name Soda Dark 3.sublime-theme
Errors parsing theme:
Animated properties must have both target and speed specified
theme loaded
reloading Packages/User/Preferences.sublime-settings
found 1 files for base name Soda Dark 3.sublime-theme
Errors parsing theme:
Animated properties must have both target and speed specified
theme loaded
Reloading /Users/ridgway/Library/Application Support/Sublime Text 3/Packages/User/Preferences.sublime-settings
ignored packages updated to: [Markdown, Vintage]
found 1 files for base name Soda Dark 3.sublime-theme
reloading Packages/User/Package Control.sublime-settings
Errors parsing theme:
Animated properties must have both target and speed specified
theme loaded
reloading Packages/User/Preferences.sublime-settings
found 1 files for base name Soda Dark 3.sublime-theme
Errors parsing theme:
Animated properties must have both target and speed specified
theme loaded
reloading plugin GitGutter.git_gutter
reloading plugin GitGutter.git_gutter_change
reloading plugin GitGutter.git_gutter_compare
reloading plugin GitGutter.git_gutter_events
reloading plugin GitGutter.git_gutter_handler
reloading plugin GitGutter.git_helper
reloading Packages/GitGutter/GitGutter.sublime-settings
reloading plugin GitGutter.view_collection
found 12 files for base name Default.sublime-keymap
found 11 files for base name Main.sublime-menu
Reloading /Users/ridgway/Library/Application Support/Sublime Text 3/Packages/User/Preferences.sublime-settings

Not sure why GitGutter's showing up under "ignored packages" but it's not there after installation—neither in User or Default preferences.

jmromer commented 10 years ago

Tried it again after uninstalling the Soda Dark theme:

ignored packages updated to: [Markdown, Vintage, GitGutter]
found 1 files for base name Default.sublime-theme
theme loaded
reloading Packages/User/Preferences.sublime-settings
found 1 files for base name Default.sublime-theme
theme loaded
Reloading /Users/ridgway/Library/Application Support/Sublime Text 3/Packages/User/Preferences.sublime-settings
reloading Packages/User/Package Control.sublime-settings
ignored packages updated to: [Markdown, Vintage]
found 1 files for base name Default.sublime-theme
theme loaded
reloading Packages/User/Preferences.sublime-settings
reloading plugin GitGutter.git_gutter
reloading plugin GitGutter.git_gutter_change
reloading plugin GitGutter.git_gutter_compare
reloading plugin GitGutter.git_gutter_events
reloading plugin GitGutter.git_gutter_handler
reloading plugin GitGutter.git_helper
reloading Packages/GitGutter/GitGutter.sublime-settings
reloading plugin GitGutter.view_collection
found 12 files for base name Default.sublime-keymap
found 11 files for base name Main.sublime-menu
found 1 files for base name Default.sublime-theme
theme loaded
Reloading /Users/ridgway/Library/Application Support/Sublime Text 3/Packages/User/Preferences.sublime-settings

It looks like Package Manager temporarily adds and then removes any package it's installing/uninstalling to the ignored packages list.

Installing manually didn't help, but for some reason this fork works: https://github.com/bradsokol/VcsGutter

lucasmezencio commented 10 years ago

I have the same issue. I have already installed and reinstalled (via Package Control only) several times. And it still does not working. No errors and no folder called GitGutter under Packages folder.

I just do not know what to do.

If I install via repo cloning, the plugin works, but I want to install via Package Control as well. Can anyone help us?

Thanks!

scherichel commented 10 years ago

@lucasmezencio If you're on mac there's a package called SublimeFixMacPath

cd ~/Library/Application\ Support/Sublime\ Text\ 3/Packages/
git clone git://github.com/int3h/SublimeFixMacPath.git

After using this package GitGutter was back to normal.

aaaronic commented 9 years ago

I can offer a +1 for SublimeFixMacPath fixing my issue with GitGutter not working.

daniisco commented 9 years ago

Can someone help me. I installed sublime text 3 yesterday and I have installer Gitgutter and the Fix path but it doesnt work. What do I do?

Pictor13 commented 9 years ago

I would add that I thought to have the same issue. Then I checked better and I found a problem with PHPCS not correctly running. After fixing PHPCS there were no other errors in the console, and GitGutter seemed to be correctly installed (as in this Issue).

After a little I realised that simply PHPCS was hiding the GitGutter's icons cause of some problems in the code.

I suggest you to press CMD+SHIFT+P and execute the "PHP Code Sniffer: Turn Execute On Save Off". This way you should see correctly the icons!

If it IS installed and you DO NOT SEE any error, then everything is working ok. Just there is something else "covering" the icons. So mainly check for other extensions that could provoke the problem!

daniisco commented 9 years ago

Pictor13. When I press CMD+SHIFT+P do you want me to install the plugin PHPCs? What do you mean by execute the "PHP Code Sniffer: Turn Execute On Save Off". Sorry for the stupid question.

Pictor13 commented 9 years ago

daniisco, CMD+SHIFT+P (on OSX) is opening the "Command Palette"; the same you are getting going to the menu "Tools -> Command Palette...". That is one of the main features of Sublime, it allows you to execute whatever command you need and that is supported by Sublime. Over there you have to write "PHP Code Sniffer: Turn Execute On Save Off", or even just the starting letters or part of the words (but in sequence). You can type:

daniisco commented 9 years ago

@Pictor13 It doesn't work to click enter, nothing happens :/

Pictor13 commented 9 years ago

When you press enter you just execute the command, that makes what it says: disables the sniffing of the code. After that the other Sublime extension, "PHP Code Sniffer", doesn't interfere with "GitGutter" and should show the icons for the changes.

My suggestion is relative to my case. There could be a possibility that in your case the problem is not a conflict with PHP-CS.

plicjo commented 9 years ago

SublimeFixMacPath fixed this issue for me too.

rajankur commented 9 years ago

This solved for me:

  1. Added GitGutter in ignored_packages
  2. Restarted Sublime Text
  3. Removed GitGutter from ignored_packages
jisaacks commented 9 years ago

Is this still an issue?

trantorLiu commented 9 years ago

SublimeFixMacPath fixed this issue for me too.

amerikan commented 9 years ago

My GitGutter had stopped working after I did a Mac OSX update. The problem was being caused by Xcode, since it updated too I had to open it and agree to its terms and conditions. After that GitGutter started working again. I guess Xcode was locking up my git.

dansterrett commented 9 years ago

@amerikan's solution worked for me.

giovannibonetti commented 9 years ago

Thanks, @amerikan! :+1:

amerikan commented 9 years ago

@dansterrett @giovannibonetti Great!

I found this out after running the git in my command-line. So if your GitGutter is not working first run git in your command-line and go from there.

bfcoder commented 9 years ago

:+1: Thanks @amerikan!

emadalam commented 8 years ago

@amerikan :+1:

eko3alpha commented 8 years ago

I just updated to El Capitan and found that GitGutter was no longer working on ST3, I manually ran

git clone https://github.com/int3h/SublimeFixMacPath.git ~/Library/Application\ Support/Sublime\ Text\ 3/Packages/FixMacPath

SublimeFixMacPath https://github.com/int3h/SublimeFixMacPath

Now its working again. It appears this happens on OSX updates. I had to do this once before.

richkuo commented 8 years ago

@amerikan BRILLIANT! THANK YOU!!

achilles-tee commented 8 years ago

@amerikan's solution alternative way execute xcode-select --install in terminal will update the xcode as well.

StewartDouglas commented 8 years ago

@amerikan :+1: thanks!