Closed yckart closed 4 years ago
@yckart I only did not set them up because the keys I wanted to use ( cmd ) does not exist in Win/Lin and wasn't sure what key combo to use as an alternative.
If you would like to make a pull request I would accept it. I am already setting the key command for max_pane
so you would only need to set it for _shiftpane and _unshiftpane for Windows and Linux.
@yckart I am so sorry I missed this, I will gladly merge this in, would you mine making the following changes first:
@jisaacks Sorry, for the delay!
I thought right now a bit about that topic (bindings) and have to say, that we should re-map them. I don't really like the switch between shift
and ctrl
and as you see, the new windows-bindings are all on ctrl+alt+?
.
So, what do you think about a change?
Yeah that sounds fine.
"ctrl+alt+enter"
is used for replace_all
in the find & replace panel of Sublime Text 3. Using it in MaxPane would override this default binding. Even if it would not directly conflict, this binding would be dangerous as it is sometimes not clear whether the find & replace panel has focus. So you might replace text by accident even though a pane was to be maximized.
Setting up bindings for shift_pane
and unshift_pane
would help ST2 users only. ST3 provides the focus_neighbouring_group
out of the box with a proper default key binding. Therefore the 2 former commands are deprecated.
As you documented, we (windows/linux users) have to define our own key bindings to navigate through panes.
But why do we have to? ctr+alt+... is not used by windows nor st2. Or are there any other thoughts I've missed?