search

jisaacks / jquery.rowslide

Use jQuery.slideUp on table rows
http://plugins.jquery.com/rowslide/
Other
4 stars 1 forks source link

Do not remove row after hiding #1

Open cweiske opened 10 years ago

cweiske commented 10 years ago

I'd like to keep the rows that have been slided up, so please provide an option to not remove the rows after sliding up.

jisaacks commented 10 years ago

I haven't worked on this in a while. You have a valid point. In fact, I would go as far as to say, that this should not remove the element. This already exposes a callback that one could use to remove the element after completion anyways. So would be fine removing the call to remove altogether. That would make it more inline with the functionality of slideUp

Might be as simple as just removing this line. Not sure though, I haven't messed with this in a while.

If you want to make a PR I would be fine with that, otherwise I will look into it, but my free time is limited these days so may be a while.